Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new accounts from course's home wiki when possible #5724

Open
ragesoss opened this issue Mar 27, 2024 · 4 comments
Open

Create new accounts from course's home wiki when possible #5724

ragesoss opened this issue Mar 27, 2024 · 4 comments

Comments

@ragesoss
Copy link
Member

Current Behavior:

Both accounts created through the Dashboard itself (via account requests) and also new accounts that get created by users starting from an enroll link go to English Wikipedia. For events on other wikis, this can be confusing and also does not correctly attributed that user's own language as their home wiki since their account gets created on en.wiki.

Desired Behavior:

When possible, accounts should be created through a user's home wiki. This will need to be extensively tested for compatibility with immediate OAuth login, and also needs to account for the situation where the account creation limit has been reached and the Dashboard would need to fall back on a bot account (https://en.wikipedia.org/wiki/User:OutreachDashboardBot) that is only able to create en.wiki accounts beyond the limit.

@Abishekcs
Copy link
Contributor

Working on this 😄.

@ragesoss
Copy link
Member Author

ragesoss commented Oct 7, 2024

The issue description is somewhat incomplete, as the system does already use other wikis to create accounts in some cases (ie, account requests), but only in limited circumstances. It may be best to think of this as two issues, one for requested accounts and the other for enrollment links.

The OAuth integration is the key part for enrollment links.

@Abishekcs
Copy link
Contributor

The issue description is somewhat incomplete, as the system does already use other wikis to create accounts in some cases (ie, account requests), but only in limited circumstances. It may be best to think of this as two issues, one for requested accounts and the other for enrollment links.

The OAuth integration is the key part for enrollment links.

Got it ty.

@ragesoss

I had a few questions regarding this issue:

In the title of the issue, it mentions "Create a new account from the course's home wiki" but in the desired behavior section, it mentions user's home wiki.

Should this be user's home wiki or course's home wiki? Or does it depend on the situation? If it depends on the situation, could you please provide more details about when each applies?

Additionally, regarding this point:

"The issue description is somewhat incomplete, as the system does already use other wikis to create accounts in some cases (i.e., account requests), but only in limited circumstances."

Could you clarify what those limited circumstances are?

Thank you.😁

@ragesoss
Copy link
Member Author

ragesoss commented Dec 2, 2024

I see my description is a little muddled. Creating the account from the course's home wiki should cover it. The assumption is that a user who is a first-time editor participating, so creating their account from the course wiki will make that the user's home wiki.

The RequestedAccount records get processed by CreateRequestedAccount, which will use the course home wiki if wiki edits are enabled on that wiki (which is not the case for most wikis), and it falls back to en_wiki even in that case, the "backup_account_creator" is used.

I think for this issue, the first thing to implement would be the flow of creating an account via an enrollment link, and figuring out how to deal with the OAuth for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants