Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ongoing: Sort out CSS selector specificity #346

Open
jonnystening opened this issue Jul 10, 2017 · 1 comment
Open

Ongoing: Sort out CSS selector specificity #346

jonnystening opened this issue Jul 10, 2017 · 1 comment
Assignees
@jonnystening
Labels
enhancement

Comments

@jonnystening
Copy link
Contributor

There are a number of examples of over specific CSS selectors in the code base.

We should not be targeting symbols like below...

.symbol.symbol-american-express {}

This should be simply...

.symbol-american-express {}

Other examples include...

.icon.icon-size-lg {}
.logo.logo-bom-shield {}
.logo.logo-bsa {}
etc.
@jonnystening jonnystening self-assigned this Jul 10, 2017
@jonnystening jonnystening changed the title Sort out CSS selector specifity Sort out CSS selector specificity Aug 4, 2017
@jonnystening
Copy link
Contributor Author

I will bang away at this ticket over time; reduce over-specific selectors when I come across them

@jonnystening jonnystening changed the title Sort out CSS selector specificity Ongoing: Sort out CSS selector specificity Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonnystening jonnystening

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonnystening