Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon examples in GUI-docs #338

Closed
jonnystening opened this issue Jun 30, 2017 · 1 comment
Closed

Icon examples in GUI-docs #338

jonnystening opened this issue Jun 30, 2017 · 1 comment
Assignees
@jonnystening
Labels
docs enhancement

Comments

@jonnystening
Copy link
Contributor

Update icon documentation to use the iframe example approach, as per other modules (logos, symbols etc). This would better illustrate icon design changes back through legacy versions.

The current approach utilises GUI-docs' own GUI build (css) to render icon examples, which is fiddly and easy to miss when updating icons.
@jonnystening jonnystening self-assigned this Jun 30, 2017
This was referenced Jul 11, 2017
Open
Closed
@jonnystening
Copy link
Contributor Author

New Icons module uses the iframe example approach

fixed by WestpacCXTeam/GUI-docs@85c1de65769aded2e348d7dc550188440f065739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonnystening jonnystening

Labels
docs enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonnystening