Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Wrong example name in Containers #334

Closed
KateMacdonald opened this issue Jun 26, 2017 · 3 comments
Closed

Docs: Wrong example name in Containers #334

KateMacdonald opened this issue Jun 26, 2017 · 3 comments
Assignees
@justinspencer @jonnystening
Labels
bug docs

Comments

@KateMacdonald
Copy link
Contributor

In docs the first Panel name is 'Primary' panel, it should be 'Hero' - as it uses the 'Hero' colour.

Just a little one.
@jonnystening jonnystening self-assigned this Jun 30, 2017
@jonnystening
Copy link
Contributor

@KateMacdonald How about calling that option 'Basic panel'? Showing it's the base styling option (without modifiers), as with default buttons (labelled 'Basic buttons')?

@jonnystening
Copy link
Contributor

Lets discuss with @justinspencer

@jonnystening jonnystening reopened this Jul 11, 2017
@jonnystening jonnystening changed the title Wrong example name in Containers Docs: Wrong example name in Containers Aug 1, 2017
@jonnystening
Copy link
Contributor

We're renaming this simply 'Panel' for now, and will look at it again when we come to #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinspencer justinspencer

@jonnystening jonnystening

Labels
bug docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinspencer @jonnystening @KateMacdonald