Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when attempting to tag a face identified as "Unidentified" #459

Closed
whoopn opened this issue Dec 11, 2022 · 6 comments
Closed

Error when attempting to tag a face identified as "Unidentified" #459

whoopn opened this issue Dec 11, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@whoopn
Copy link

whoopn commented Dec 11, 2022

Error:
System.NullReferenceException: Arg_NullReferenceException at Damselfly.Web.Client.Shared.Dialogs.NameDialog.OnInitialized() at Microsoft.AspNetCore.Components.ComponentBase.RunInitAndSetParametersAsync()

Happens when I click on the "Unidentified Face".

Damselfly v4.0.2.

Is there a setting I need to turn on?

@Webreaper
Copy link
Owner

Think it's just a bug - investigating....

@Webreaper Webreaper added the bug Something isn't working label Dec 12, 2022
@Webreaper
Copy link
Owner

Can you try pulling webreaper/damselfly:dev and see if that stops the exception?

@whoopn
Copy link
Author

whoopn commented Dec 17, 2022

It takes a while for the dev to get where the non-dev is. The filter for tagged faces also seems like it doesn't filter right (or I dont know how to use it). I'll let you know if it resolves it.

@whoopn
Copy link
Author

whoopn commented Dec 18, 2022

Same error:

System.NullReferenceException: Arg_NullReferenceException
at Damselfly.Web.Client.Shared.Dialogs.NameDialog.OnInitialized()
at Microsoft.AspNetCore.Components.ComponentBase.RunInitAndSetParametersAsync()

Damselfly-20221217.log

@dhthwy
Copy link

dhthwy commented Jan 2, 2023

I tested this in develop branch and it was still throwing an exception in UpdateName in ImageRecognitionService. A few lines below I see:

if (faceObject.Person == null)
{
        faceObject.Person = new Person();
        db.People.Add(faceObject.Person);
}

So I am assuming the exception is a mistake? I created a pull request #465 to address this, and it now works for me. Nice work btw!

@Webreaper
Copy link
Owner

Exception is indeed a mistake. Good spot - thanks for fixing! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants