Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove value member of property affordances in Thing Descriptions #2854

Open
benfrancis opened this issue Jul 22, 2021 · 1 comment
Open
Labels
bug w3c-compliance wot-thing-description W3C WoT Thing Description specification
Milestone

Comments

@benfrancis
Copy link
Member

benfrancis commented Jul 22, 2021

For some reason the /things endpoint on the gateway includes a value member in each property affordance which provides the value of the property at the time the resource was requested. It has been noted that there are circumstances under which it also reports the wrong value.

I'm not sure how long it has been this way but according to the API specification property values should not be included in the Things resource, they should only be returned when fetching a Property resource or Properties resource. This is also not W3C compliant.

We should remove the value member from the Thing Descriptions, but before we do that we need to check whether this is consumed in the front end anywhere.

@benfrancis benfrancis added this to the 2.0 milestone Jul 22, 2021
@benfrancis benfrancis added the bug label Jul 22, 2021
@benfrancis
Copy link
Member Author

Note: The values also appear in Thing resources (Thing Descriptions) and we should make sure they're removed from there too.

This may be limited to certain adapters. It's reproduceable with the Virtual Things adapter.

@benfrancis benfrancis changed the title Remove values of properties from Things resource in Web Thing API Remove value member from Thing Descriptions Jul 22, 2021
@benfrancis benfrancis changed the title Remove value member from Thing Descriptions Remove value member of property affordances in Thing Descriptions Jul 22, 2021
@benfrancis benfrancis added the wot-thing-description W3C WoT Thing Description specification label Jul 26, 2021
@benfrancis benfrancis moved this to Product Backlog in WebThings Gateway Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug w3c-compliance wot-thing-description W3C WoT Thing Description specification
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant