-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close requests and close watchers #215
Comments
Is there an explanation somewhere as to why Android cannot synthesize |
Chrome intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/jM5au7yYzHM/m/L8r7x5CmAAAJ |
Just as an fyi this has been merged into the html spec and shipped in |
This has gone through some iteration in the spec and chrome implementation to handle some edge cases better. As a result it should be even more stable to implement in WebKit. It would be good to get an official signal of support or feedback on possible changes to achieve that, (especially as it's currently unshipped in chrome while it went through some of these changes) |
Colleagues and I looked at this again and are still not entirely convinced it's worth the complexity given that for Apple platforms at least this is essentially what the |
@domenic could you update the URL to point to the actual spec at https://html.spec.whatwg.org/multipage/interaction.html#close-requests-and-close-watchers and the URL repo link to point to the html spec? Else the links on webkit.org will end up being outdated. |
I updated the URL. The repository still seems accurate? It's not archived anyway. Will update webkit.org later. |
WebKittens
@annevk and @othermaciej have both previously reviewed this
Title of the spec
Close signals and close watchers
URL to the spec
https://html.spec.whatwg.org/multipage/interaction.html#close-requests-and-close-watchers
URL to the spec's repository
https://github.com/WICG/close-watcher
Issue Tracker URL
No response
Explainer URL
No response
TAG Design Review URL
w3ctag/design-reviews#594
Mozilla standards-positions issue URL
mozilla/standards-positions#604
WebKit Bugzilla URL
No response
Radar URL
No response
Description
In addition to the WICG repository with the explainer, see the HTML Standard pull request: whatwg/html#9462
The main new API introduced here is the
CloseWatcher
API. But this spec also includes changes to unify dialog, popover, and fullscreen handling into a single "close watcher" concept, which is triggered by a platform-independent concept of "close request".For macOS and keyboard-attached iOS devices, the close request would be the Esc key. For other iOS devices, there might not be a close request. This was previously discussed in WICG/close-watcher#11 ; see also https://github.com/WICG/close-watcher/blob/main/platform-implementation-notes.md . In such cases, it would still be ideal for the API to exist and be implemented, and just never triggered via user action, so that developers can write platform-agnostic code (e.g. centralizing their close logic into the
close
event handler of aCloseWatcher
object).Because of how close request gestures can serve multiple purposes, e.g. the Android back button/gesture being used to navigate session history, the specification has some anti-abuse measures to prevent the close signal gesture from being indefinitely captured by web developers using dialogs, popovers, or
CloseWatcher
s. These measures might not be necessary in the macOS/iOS-with-keyboard ecosystem, where the Esc key is the only relevant gesture and it does not serve another purpose. But we think they're still reasonable, and should be implemented uniformly across platforms for interoperability. This was previously discussed from one angle in WICG/close-watcher#10.The text was updated successfully, but these errors were encountered: