Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedometer About format & readme links #294

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

flashdesignory
Copy link
Contributor

@flashdesignory flashdesignory commented Aug 11, 2023

  1. Added links to readme files for workloads (all readme files have now consistent casing, hence more changed files)

  2. Updated CSS rules for the about page:

Screenshot 2023-08-11 at 12 21 52 PM Screenshot 2023-08-11 at 12 21 59 PM

Todo: Complex DOM versions need readme files at a certain point

@kara

@@ -126,10 +126,13 @@ The Angular version of the TodoMVC uses components such as `<app-todo-header>`,
Ex. `<app-todo-list>` wraps around `<main>` which is different from the other implementations of the TodoMVC. The CSS generator doesn't know about this and will generate a selector like this:

```css
section > .main
section > .main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format on root changed a few things here

@flashdesignory flashdesignory requested a review from rniwa August 14, 2023 15:44
@rniwa rniwa added the trivial change A change that doesn't affect benchmark results label Aug 22, 2023
@flashdesignory flashdesignory merged commit f841f81 into WebKit:main Aug 22, 2023
@flashdesignory flashdesignory deleted the about-readme branch October 18, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial change A change that doesn't affect benchmark results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants