-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WiP] - Improving the Settings SYNC of the Primary/Replica Indices #319
base: main
Are you sure you want to change the base?
Conversation
Hi @mskapusuz This is looking intriguing and also a different method than I was likely originally thinking in my ongoing comments in #317, which I'm not complaining about. Let us know if you want some early testing of things or at least once you feel it's ready for formal testing, and we can help kick the tires. |
Hey @tw2113 Great! I will notify you as soon as it is ready for early testing. Thank you! |
Hey @tw2113 I'm available to work on this again. The remaining things seem to:
Do you think the forceful push ability can be helpful? |
Hey Daniel, @w3bdesign I'm Mustafa. As I see, you've approved that. Thanks for your contribution. |
I don't have answers for the first item, but that'd be the first thing I'd suggest focusing on. I'm not as immediately worried about code style/PHPCS as I would be about functionality. |
Thank you! I think that ability helps to be adapted for potential changes on the Algolia side. Therefore, I would like to implement it. I'll let you know when it's done. |
561c578
to
24f6bdf
Compare
34711b4
to
c8a97f8
Compare
… for exceptions other than "index does not exist")
The PR aims prevents overriding remote Algolia Index Settings.
Key features
PR description will be updated when the PR is ready for the review.
Closes #317