Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$.closest() instead of parents() #828

Closed
wants to merge 1 commit into from
Closed

Conversation

anhskohbo
Copy link
Contributor

In case I have a li tag wrapper .cmb-row, click (x) button will remove li parent.
Fixed that with closest() method.

In case I have a `li` tag wrapper `.cmb-row`, click (x) button will remove li parent.
Fixed that with closest() method.
@jtsternberg
Copy link
Member

Thanks for submitting. Can you explain to me the scenario that makes this necessary? Not sure I understand the li tag wrapper thing.

@anhskohbo
Copy link
Contributor Author

My english is not good, so pls see this gif below :)

peek 2017-01-07 11-40

@jtsternberg
Copy link
Member

This update should fix the issue. I've introduced a shared class that it targets instead of the li element.

@anhskohbo anhskohbo deleted the patch-1 branch January 7, 2017 05:04
@anhskohbo
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants