Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed undefined variable: page_type #779

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Fixed undefined variable: page_type #779

merged 1 commit into from
Oct 25, 2016

Conversation

anhskohbo
Copy link
Contributor

You're missing $page_type variable :)

You're missing $page_type variable :)
@tw2113
Copy link
Contributor

tw2113 commented Oct 25, 2016

Not quite sure what this is supposed to fix, to be honest. The original version in the line changed would return a value right away. All you're ending up doing is assigning that to a variable, inside an if statement. Never been a fan of variable assignment inside if statements myself.

Is this fixing an open issue at all? or just casual looking over of the code?

@anhskohbo
Copy link
Contributor Author

You can look $page_type never declared before.

@tw2113
Copy link
Contributor

tw2113 commented Oct 25, 2016

Gotcha.

@jtsternberg jtsternberg merged commit 5fccab9 into CMB2:trunk Oct 25, 2016
@jtsternberg
Copy link
Member

Thank you sir.

@anhskohbo anhskohbo deleted the fix-page-type branch October 25, 2016 18:05
@anhskohbo
Copy link
Contributor Author

You're welcome :)

jtsternberg added a commit that referenced this pull request Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants