Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700.
Discussion: https://wordpress.org/support/topic/term-meta-is-saved-but-it-doesnt-appear-in-term-edit-screen-later/page/2/#post-8259773
So order matters here due to the caching pattern used in CMB2_
Which I think explains why different folks report different results. Depending on the order things get initialized in, object_type could be set differently.
However, in the case where nothing else is setting object_type (this only happens during
render_form_open
andrender_form_close
), then in the above logic, current_object_type is NEVER called, because $this->object_type is already defaulted to 'post'.If you remove that default, everything works great!
Changes proposed in this pull request
object_type
to null for CMB2_Base