Path issues with JS and CSS #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! In the future, please submit PRs to the trunk branch. More info in the CONTRIBUTING.md. |
jtsternberg
added a commit
that referenced
this pull request
Jun 29, 2016
|
Thanks. I will use Trunk in future. |
jtsternberg
added a commit
that referenced
this pull request
Jun 30, 2016
|
Yah, it's all good though: https://travis-ci.org/WebDevStudios/CMB2/builds/141121919 |
|
Great. Will Composer get updated automatically? I see it is still behind. |
|
Not until I put out a new release. You'll have to map to trunk directly for now. |
|
OK. I've already done that. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve issues with asset paths on Windows/Xampp
The ABSPATH ($site_dir) is run through your normalize path function as you already do with $dir inside get_url_from_dir()
Fixes #676