datepicker and timepicker fixes #318

yivi · 2015-05-08T17:11:00Z

Support for date-format and time-format in text_date and text_time fields. They accept a php formatted string, which is converted to a js formatted string and injected in the data attribute so the pickers can be initialized appropriately. Fixes #282, fixes #300

…d of just trying strtotime directly

…tialized with its own date-format The js initializer reads data-datepicker to set each datepicker properly

…at options for the datepickers

…e characters into your date-format string

…ttribute as in date-picker)

Conflicts: includes/CMB2_Sanitize.php includes/CMB2_Types.php js/cmb2.min.js languages/cmb2-es_ES.mo languages/cmb2-es_ES.po

Conflicts: js/cmb2.min.js languages/cmb2-es_ES.mo languages/cmb2-es_ES.po

jtsternberg · 2015-07-09T19:07:03Z

Thanks a ton for putting time in to work on this issue. To help me better review your PR, I have a few requests:

Remove all edits/changes that are not related to this bug-fix/issue
Remove all white-space changes (same as above). This includes doc-block edits.
Try to keep your PR as focused on solving a single problem as possible

I like the edits you made (better doc-blocks, etc), but these things should be separate PRs. It's much easier to merge a PR that is simply doc-block edits than one that is changing functionality, or worse, both.

Can you submit separate PRs to split these concerns and make it easier to review/merge? Thank you.

yivi · 2015-07-11T07:56:40Z

Hi there. Will do!

Sorry about those side tracked changes. Code style happened because I had my ide to auto format to wp guidelines on save and didn't realize, and the docblocks was probably me going over the code inspection notices and warnings before committing.

I'll make this changes on Monday eve. Regards and have a nice weekend!

—
Sent from Mailbox

On Thu, Jul 9, 2015 at 9:07 PM, Justin Sternberg [email protected]
wrote:

Thanks a ton for putting time in to work on this issue. To help me better review your PR, I have a few requests:

Remove all edits/changes that are not related to this bug-fix/issue

Remove all white-space changes (same as above). This includes doc-block edits.

Try to keep your PR as focused on solving a single problem as possible
I like the edits you made (better doc-blocks, etc), but these things should be separate PRs. It's much easier to merge a PR that is simply doc-block edits than one that is changing functionality, or worse, both.
Can you submit separate PRs to split these concerns and make it easier to review/merge? Thank you.
Reply to this email directly or view it on GitHub:
datepicker and timepicker fixes #318 (comment)

jtsternberg · 2015-07-11T13:47:10Z

Ok thanks again! I really do like the formatting cleanup, so feel free to submit another separate PR if you're up for it.

yivi · 2015-07-13T18:05:09Z

I think I removed all formatting changes from the PR.
Let me know if you see something you think it would benefit from a bit more work.

Regards!

jtsternberg · 2015-07-14T12:59:26Z

Thank you for cleaning it up, that helps a ton. Now that I can see what's going on, I see you are using DateTime::createFromFormat which unfortunately is a PHP 5.3 feature. We have to support the same versions of PHP that WordPress does, which is 5.2.4. Maybe you can check if that feature exists and use it and if not, create a fallback solution?

yivi · 2015-07-14T18:40:34Z

5.2... I hope WP Core gets up to speed at some point; 5.2 has been eol for more than 4 years now... and 7 is around the corner. :P

Pushed a new version that checks if create_date_from_format exists, and defines it if not.

Thanks and regards!

jtsternberg · 2015-07-29T15:59:33Z

@yivi Why didn't you update the text_datetime_timestamp field type w/ your changes? I'm concerned that the changes you've made are not taking all the field types and/or scenarios into account.

jtsternberg · 2015-07-29T16:44:41Z

Nice work so far. I've merged your branch into trunk and created a new branch. let's collaborate on this branch instead of trunk until it's ready to go: https://github.com/WebDevStudios/CMB2/tree/yivi-date-time-picker-fixes

yivi · 2015-08-15T08:52:32Z

Sorry for the late reply. I was out on holidays on a cycling trip, very
much away from the keyboard.

I'll resume work this week. I'll take a look a at what's left, hopefully we
can have everything wrapped up soon enough.

Regards!

2015-07-29 18:44 GMT+02:00 Justin Sternberg [email protected]:

Nice work so far. I've merged your branch into trunk and created a new
branch. let's collaborate on this branch instead of trunk until it's ready
to go:
https://github.com/WebDevStudios/CMB2/tree/yivi-date-time-picker-fixes

—
Reply to this email directly or view it on GitHub
#318 (comment).

jtsternberg · 2015-09-03T13:32:51Z

This is almost good to go. Just need to make sure that all the date type fields are accounted for in this change.

jtsternberg · 2015-10-07T15:56:27Z

@yivi will you be able to add support for ALL the date type fields?

tw2113 · 2015-10-07T15:57:01Z

Is there any way we could add in fetching the date_format option from the user's General Settings as a default format value as well?

jtsternberg · 2015-10-07T15:57:22Z

Also, how does this differ from #446?

yivi · 2015-10-08T18:39:49Z

Justin,

I've tried my fixes with all these date/time fields, and they are working:

text_date_timestamp
https://github.com/WebDevStudios/CMB2/wiki/Field-Types#text_date_timestamp
Date Picker (UNIX timestamp)
text_datetime_timestamp
https://github.com/WebDevStudios/CMB2/wiki/Field-Types#text_datetime_timestamp
Text Date/Time Picker Combo (UNIX timestamp)
text_datetime_timestamp_timezone
https://github.com/WebDevStudios/CMB2/wiki/Field-Types#text_datetime_timestamp_timezone
Text Date/Time Picker/Time zone Combo
text_time
https://github.com/WebDevStudios/CMB2/wiki/Field-Types#text_time Time
picker
fix so datetime combo field respects date-format and time format a set up by the user #446 relates to text_datetime_timestamp_timezone, which is covered, right?

Regards

2015-10-07 17:57 GMT+02:00 Justin Sternberg [email protected]:

Also, how does this differ from #446
#446?

—
Reply to this email directly or view it on GitHub
#318 (comment).

yivi · 2015-10-08T20:34:30Z

Just merged current trunk and tested it on a couple of working sites.

Things look good.

2015-10-08 20:39 GMT+02:00 Yivi [email protected]:

Justin,

I've tried my fixes with all these date/time fields, and they are working:

text_date_timestamp
https://github.com/WebDevStudios/CMB2/wiki/Field-Types#text_date_timestamp
Date Picker (UNIX timestamp)

text_datetime_timestamp
https://github.com/WebDevStudios/CMB2/wiki/Field-Types#text_datetime_timestamp
Text Date/Time Picker Combo (UNIX timestamp)

text_datetime_timestamp_timezone
https://github.com/WebDevStudios/CMB2/wiki/Field-Types#text_datetime_timestamp_timezone
Text Date/Time Picker/Time zone Combo

text_time
https://github.com/WebDevStudios/CMB2/wiki/Field-Types#text_time Time
picker
fix so datetime combo field respects date-format and time format a set up by the user #446 relates to text_datetime_timestamp_timezone, which is covered, right?

Regards

2015-10-07 17:57 GMT+02:00 Justin Sternberg [email protected]:

Also, how does this differ from #446
#446?

—
Reply to this email directly or view it on GitHub
#318 (comment).

yivi · 2015-10-21T08:13:55Z

Work continued in #446

yivi added 20 commits May 8, 2015 09:35

updated Spanish translations

afb4069

Fixes text_date_timestamp validation so it uses 'date_format', instea…

a286f03

…d of just trying strtotime directly

Outputs data-datepicker into date_text, so each datepicker can be ini…

26a9b73

…tialized with its own date-format The js initializer reads data-datepicker to set each datepicker properly

function to convert between php date-format options, and js date-form…

128cecb

…at options for the datepickers

stripslashes in format_timestamp made it so you couldn't insert escap…

dddc86d

…e characters into your date-format string

Aditional options to convert time formats from php to js

d3d8c23

time-format options are recognized by the time-picker (using a data a…

35bb37f

…ttribute as in date-picker)

@return missing in some phpdoc blocks

e0331f5

Merge remote-tracking branch 'upstream/trunk' into trunk

f44be5f

Conflicts: includes/CMB2_Sanitize.php includes/CMB2_Types.php js/cmb2.min.js languages/cmb2-es_ES.mo languages/cmb2-es_ES.po

old style array declaration, to make Travis happy.

4edf1f1

Removed anoymous function to satisfy Travis (PHP 5.2)

b068a3f

Another old style array declaration to satisfy Travis

4df29b4

Updating tests. Crossing fingers.

70e3b50

yet another new style to old style array declaration

0e36e09

yet another new style to old style array declaration...

7d5421e

a couple more new style array declarations to 5.2 style

65ca940

and an array declaration in a return statement

ed17942

hopefully the last > 5.2 array declaration. :(

3be00da

Merge remote-tracking branch 'upstream/trunk' into trunk

7087f8d

Conflicts: js/cmb2.min.js languages/cmb2-es_ES.mo languages/cmb2-es_ES.po

proper doc-type for phpdoc in text_date_timestamp

3098d59

yivi added 2 commits July 13, 2015 19:34

Merge remote-tracking branch 'upstream/trunk' into trunk

7a03730

removed formatting/docblock changes

af4f02a

yivi mentioned this pull request Jul 13, 2015

Tidy up #383

Closed

Workaround for create_date_from_format not existing in PHP < 5.3

fe72981

jtsternberg mentioned this pull request Aug 1, 2015

Setting up options for datetimepicker #378

Open

mweimerskirch mentioned this pull request Oct 19, 2015

Support for custom "date_format" and "time_format" arguments #498

Closed

yivi closed this Oct 21, 2015

yivi deleted the trunk branch October 22, 2015 15:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

datepicker and timepicker fixes #318

datepicker and timepicker fixes #318

yivi commented May 8, 2015

jtsternberg commented Jul 9, 2015

yivi commented Jul 11, 2015

jtsternberg commented Jul 11, 2015

yivi commented Jul 13, 2015

jtsternberg commented Jul 14, 2015

yivi commented Jul 14, 2015

jtsternberg commented Jul 29, 2015

jtsternberg commented Jul 29, 2015

yivi commented Aug 15, 2015

jtsternberg commented Sep 3, 2015

jtsternberg commented Oct 7, 2015

tw2113 commented Oct 7, 2015

jtsternberg commented Oct 7, 2015

yivi commented Oct 8, 2015

yivi commented Oct 8, 2015

yivi commented Oct 21, 2015

datepicker and timepicker fixes #318

datepicker and timepicker fixes #318

Conversation

yivi commented May 8, 2015

jtsternberg commented Jul 9, 2015

yivi commented Jul 11, 2015

jtsternberg commented Jul 11, 2015

yivi commented Jul 13, 2015

jtsternberg commented Jul 14, 2015

yivi commented Jul 14, 2015

jtsternberg commented Jul 29, 2015

jtsternberg commented Jul 29, 2015

yivi commented Aug 15, 2015

jtsternberg commented Sep 3, 2015

jtsternberg commented Oct 7, 2015

tw2113 commented Oct 7, 2015

jtsternberg commented Oct 7, 2015

yivi commented Oct 8, 2015

yivi commented Oct 8, 2015

yivi commented Oct 21, 2015