-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does your plugin work on "Update" Post ? #62
Comments
OK, it works fine now. Seems as custom filter to increase character limit in conjunction with non-gutenberg WP repository code made something. Transient possible, do not know. Installed latest Master code from Github for Gutenberg support. Old filter still works. As any possible slowdown will be only annoyance for one person, Editor/Admin and in backend only I personaly do not have any problem to increase it to virtually unlimited.
Please update WP repository code to Gutenberg support. It works, old character limit filter works too. |
Found a problem. Once featured image is removed from Metabox it is not possible to trigger it again. No matter if YT link is changed. |
Regarding Gutenberg stuff, see #59 Also seeing https://github.com/WebDevStudios/Automatic-Featured-Images-from-Videos/blob/master/automatic-featured-images-from-videos.php#L103 which i forgot about, but may need updated. Regarding the rest, it should be running on the save_post hook, which runs pretty frequently, and also should be checking if having a post thumbnail set already and add/set if not starting around https://github.com/WebDevStudios/Automatic-Featured-Images-from-Videos/blob/master/automatic-featured-images-from-videos.php#L136 First time hearing about these issues, so I won't outright say it's not happening, but would need extra testing to confirm. |
Have some problems to make it work. (Updated with latest Branche for Gutenberg support).
Only first time it worked. (On Save, Publish)
Does it work on "Update" Post ?
The text was updated successfully, but these errors were encountered: