Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does your plugin work on "Update" Post ? #62

Open
StaggerLeee opened this issue Feb 10, 2019 · 3 comments
Open

Does your plugin work on "Update" Post ? #62

StaggerLeee opened this issue Feb 10, 2019 · 3 comments

Comments

@StaggerLeee
Copy link

StaggerLeee commented Feb 10, 2019

Have some problems to make it work. (Updated with latest Branche for Gutenberg support).

Only first time it worked. (On Save, Publish)
Does it work on "Update" Post ?

@StaggerLeee
Copy link
Author

StaggerLeee commented Feb 10, 2019

OK, it works fine now. Seems as custom filter to increase character limit in conjunction with non-gutenberg WP repository code made something. Transient possible, do not know.

Installed latest Master code from Github for Gutenberg support. Old filter still works. As any possible slowdown will be only annoyance for one person, Editor/Admin and in backend only I personaly do not have any problem to increase it to virtually unlimited.

function reelism_larger_content_scan( $length ) { return 320000000; } add_filter( 'wds_featured_images_character_limit', 'reelism_larger_content_scan' );

Please update WP repository code to Gutenberg support. It works, old character limit filter works too.

@StaggerLeee
Copy link
Author

Found a problem. Once featured image is removed from Metabox it is not possible to trigger it again. No matter if YT link is changed.

@StaggerLeee StaggerLeee reopened this Feb 10, 2019
@tw2113
Copy link
Member

tw2113 commented Feb 10, 2019

Regarding Gutenberg stuff, see #59 Also seeing https://github.com/WebDevStudios/Automatic-Featured-Images-from-Videos/blob/master/automatic-featured-images-from-videos.php#L103 which i forgot about, but may need updated.

Regarding the rest, it should be running on the save_post hook, which runs pretty frequently, and also should be checking if having a post thumbnail set already and add/set if not starting around https://github.com/WebDevStudios/Automatic-Featured-Images-from-Videos/blob/master/automatic-featured-images-from-videos.php#L136

First time hearing about these issues, so I won't outright say it's not happening, but would need extra testing to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants