Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "add an allowed Bluetooth device" algorithm does not actually add the device #639

Open
tidoust opened this issue Jan 17, 2025 · 1 comment

Comments

@tidoust
Copy link
Contributor

tidoust commented Jan 17, 2025

Unless I missed something, step 4.1 in the add an allowed Bluetooth device algorithm handles the case where no device is found in allowedDevices but:

  • does not initialize allowedDevice, whereas the starting point is "If one [allowedDevice] is not found"
  • does not add the allowedDevice to the storage, which it probably should?
@reillyeon
Copy link
Contributor

The first issue is probably fixed by just changing required sequence<AllowedBluetoothDevice> allowedDevices; to required sequence<AllowedBluetoothDevice> allowedDevices; = []; in the definition of BluetoothPersistentStorage.

The second issue just requires another step after initializing allowedDevice.deviceId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants