Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using indices rather than names for symbol identifiers #30

Closed
sunfishcode opened this issue Dec 7, 2017 · 5 comments
Closed
Labels

Comments

@sunfishcode
Copy link
Member

A syminfo currently identifies its symbol by name. It seems like it would be simpler, more consistent with wasm encoding in general, and consistent with the ELF-like principle of not referring to symbols within the same module by name, and possibly faster to link, if it identified symbols by index.

It would also work well with #29, in case it became important to add symbol flags to local symbols, because local symbols have indices.

It would need some way to indicate the type of index: function, global, table, or memory. I expect we could either split WASM_SYMBOL_INFO into 4 codes, WASM_FUNCTION_SYMBOL_INFO and so on, or we could add external_kind bytes.

@NWilson
Copy link
Contributor

NWilson commented Jan 17, 2018

Under review: https://reviews.llvm.org/D42117

@sbc100
Copy link
Member

sbc100 commented Jan 18, 2018

Could you create PR to update Linking.md accordingly?

@sbc100
Copy link
Member

sbc100 commented Jan 20, 2018

If we go ahead with this plan then this will be fixed and we will get rid of SYMBOL_INFO completely:
#38

@sbc100
Copy link
Member

sbc100 commented Jan 20, 2018

We can reopen if #38 doesn't happen.

@NWilson
Copy link
Contributor

NWilson commented Feb 23, 2018

Can close now

@sbc100 sbc100 closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants