Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not unsafe-wasm-eval? #15

Closed
annevk opened this issue Aug 24, 2018 · 3 comments
Closed

Why not unsafe-wasm-eval? #15

annevk opened this issue Aug 24, 2018 · 3 comments

Comments

@annevk
Copy link
Member

annevk commented Aug 24, 2018

It's not clear to me why we'd deviate from the CSP naming precedent.

@titzer
Copy link
Contributor

titzer commented Aug 29, 2018

I don't feel strongly about the naming, other than we might have a compatibility issue with what has already been implemented in Chrome (https://cs.chromium.org/chromium/src/extensions/common/csp_validator.cc?q=wasm-eval&sq=package:chromium&dr=C&l=208).

It might be hair splitting, but JavaScript eval is unsafe for a number of reasons that don't apply to wasm, so naming it "wasm-eval" is a way to just state "just the facts ma'am" and leave out value judgements :-)

@annevk
Copy link
Member Author

annevk commented Aug 29, 2018

It's not a value judgment. It makes it clear to policy authors what the risks are. And the risks are definitely similar, if not the same.

cc @mikewest

@titzer
Copy link
Contributor

titzer commented Sep 3, 2018

@annevk I can see that argument. If there is consensus for unsafe-wasm-eval, then in Chrome we can implement the new directive and keep the old as a deprecated alias for some transition time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants