Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leaks in DiagnosticsLogger.handlePipeNotification #65

Closed
tomislav opened this issue Apr 25, 2020 · 4 comments · Fixed by #68
Closed

Memory leaks in DiagnosticsLogger.handlePipeNotification #65

tomislav opened this issue Apr 25, 2020 · 4 comments · Fixed by #68
Assignees

Comments

@tomislav
Copy link

I'm getting memory leaks DiagnosticsLogger.handlePipeNotification. I'm not sure if this is an actual leak or the NSData object being created is being added to an autorelease pool. Does anyone else experience this?

Screenshot 2020-04-25 at 11 15 09

@AvdLee AvdLee self-assigned this May 25, 2020
@AvdLee
Copy link
Contributor

AvdLee commented May 25, 2020

I found out that this is caused by the readInBackgroundAndNotify. I've been able to solve this, a PR is coming up!

@ghost
Copy link

ghost commented May 27, 2020

The pull request #68 that closed this issue was merged and released as part of Release 1.7.0 🚀
Please let us know if the functionality works as expected as a reply here. If it does not, please open a new issue. Thanks!

Generated by GitBuddy

@tomislav
Copy link
Author

@AvdLee Thank you. I can confirm that the memory leaks are gone in 1.7.0.

I'm using Diagnostics for Bluelane. It really helped me figure out some obscure bugs by having users send their logs.

@AvdLee
Copy link
Contributor

AvdLee commented May 28, 2020

That's great, @tomislav! Thanks again for reporting in, it caused quite a few bugs apparently in our Share Extension due to memory issues 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants