Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layer-shell: adjust keyboard-interactivity #962

Merged
merged 1 commit into from
Jan 6, 2021
Merged

layer-shell: adjust keyboard-interactivity #962

merged 1 commit into from
Jan 6, 2021

Conversation

dkondor
Copy link
Contributor

@dkondor dkondor commented Dec 18, 2020

Implementation for swaywm/wlr-protocols#100 -- requires swaywm/wlroots#2555 to actually work.

Only a value of 1 is interpreted as a request for exclusive focus. Other > 0 values result in normal focus semantics.

@dkondor dkondor mentioned this pull request Dec 18, 2020
Merged
@dkondor dkondor force-pushed the layer_shell_keyboard branch from 3063073 to 8c1515d Compare December 18, 2020 11:29
@ammen99 ammen99 marked this pull request as draft December 18, 2020 11:34
@ammen99
Copy link
Member

ammen99 commented Dec 18, 2020

Marking as draft simply because the wlroots PR is not merged yet. Otherwise, LGTM.

@wb9688
Copy link
Contributor

wb9688 commented Dec 18, 2020

Other > 0 values result in normal focus semantics.

Shouldn't values > 2 result in an error? Or is that already handled by wlroots then?

@dkondor
Copy link
Contributor Author

dkondor commented Dec 19, 2020

Other > 0 values result in normal focus semantics.

Shouldn't values > 2 result in an error? Or is that already handled by wlroots then?

Yes, I think it is better to handle this in wlroots (unless other compositor implementations will want to be able to add their custom values):
https://github.com/swaywm/wlroots/blob/b4786c166d0f2eca1df7a1597910f1f9b05022b6/types/wlr_layer_shell_v1.c#L164

@dkondor dkondor force-pushed the layer_shell_keyboard branch from 8c1515d to 37e3e09 Compare December 28, 2020 12:55
@dkondor
layer-shell: adjust keyboard-interactivity
5c15711 
Only a value of 1 is interpreted as a request for exclusive focus. Other > 0 values result in normal focus semantics.
@dkondor dkondor force-pushed the layer_shell_keyboard branch from 37e3e09 to 5c15711 Compare January 2, 2021 04:20
@ammen99
Copy link
Member

ammen99 commented Jan 6, 2021

Hmm, actually, this would work on the current wlroots master too, right (we could merge this without breaking anything)?

@dkondor
Copy link
Contributor Author

dkondor commented Jan 6, 2021

Yes, I agree, it should not break anything, since wlroots always sets it to 0/1 currently.

@ammen99 ammen99 marked this pull request as ready for review January 6, 2021 09:28
ammen99
ammen99 approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's merge it then. Thanks!

@ammen99 ammen99 merged commit e76c94e into WayfireWM:master Jan 6, 2021
@dkondor dkondor mentioned this pull request Jan 7, 2021
Merged
@emersion
Copy link

emersion commented Jan 7, 2021

Is the keyboard_interactivity == 2 case already implemented in Wayfire?

@ammen99
Copy link
Member

ammen99 commented Jan 7, 2021

Is the keyboard_interactivity == 2 case already implemented in Wayfire?

Not explicitly, but it will "just work" without any special casing.

@dkondor dkondor deleted the layer_shell_keyboard branch January 24, 2021 15:45
This was referenced Jul 23, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammen99 ammen99 ammen99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dkondor @ammen99 @wb9688 @emersion