Fix memory leak when activating cube plugin #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcolitti
force-pushed
the
fix-cube-leak
branch
2 times, most recently
from
e638a73 to
d9a9a88
Compare
Currently it looks like the framebuffers are allocated on activate but never released. This causes a substantial memory leak. Fix this by adding a destructor to cube_render_instance_t that releases them. Fixes WayfireWM#2059
lcolitti
force-pushed
the
fix-cube-leak
branch
from
d9a9a88 to
8d1cd34
Compare
mrsteve0924
pushed a commit
to mrsteve0924/wayfire
that referenced
this pull request
Mar 2, 2024
Currently it looks like the framebuffers are allocated on activate but never released. This causes a substantial memory leak. Fix this by adding a destructor to cube_render_instance_t that releases them. Fixes WayfireWM#2059
ammen99
pushed a commit
that referenced
this pull request
Mar 13, 2024
Currently it looks like the framebuffers are allocated on activate but never released. This causes a substantial memory leak. Fix this by adding a destructor to cube_render_instance_t that releases them. Fixes #2059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it looks like the framebuffers are allocated on activate but never released. This causes a substantial memory leak. Fix this by adding a destructor to cube_render_instance_t that releases them.
Fixes #2059