plugin-loader: Only load plugins once #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate plugins are now ignored. Fixes #2036.
|
We already have a check for this wayfire/src/core/plugin-loader.cpp Line 203 in 9947528 The only question is why it doesn't work |
|
Oh, I see. We ought to make sure the plugin isn't duplicated in the pending plugins as well. |
|
If I am understanding correctly, this PR would make it so the latter non-working check is not needed. |
|
Thanks @soreau for the initial work on this :) |
mrsteve0924
pushed a commit
to mrsteve0924/wayfire
that referenced
this pull request
Mar 2, 2024
* plugin-loader: Only load plugins once Duplicate plugins are now ignored. Fixes WayfireWM#2036. --------- Co-authored-by: Ilia Bozhinov <[email protected]>
ammen99
added a commit
that referenced
this pull request
Mar 13, 2024
* plugin-loader: Only load plugins once Duplicate plugins are now ignored. Fixes #2036. --------- Co-authored-by: Ilia Bozhinov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate plugins are now ignored.
Fixes #2036.