Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement keyboard-shortcuts-inhibitor-v1 #1969

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Conversation

ammen99
Copy link
Member

@ammen99 ammen99 commented Oct 21, 2023

Supersedes #1372
Thanks to @lilydjwg for doing the initial work, it was certainly helpful :)

Fixes #1171

This PR adds support for the keyboard-shortcuts-inhibit-v1 protocol via the new shortcuts-inhibit plugin.
I have also added a few nice-to-have functions:

  • The user can specify that certain apps 'grab' input even though they do not use the protocol. For example, I use shortcuts-inhibit/inhibit_by_default set to app_id is "wlroots" so that nested Wayfire can use the same shortcuts as the host.
  • The user can specify a specific keybinding to break the grab. I have shortcuts-inhibit/break_grab set to <ctrl> <alt> KEY_ESC (disabled by default though).

It would be nice if someone else could also test and verify that this works. I have only checked the wlroots example.

@ammen99 ammen99 mentioned this pull request Oct 21, 2023
@ammen99 ammen99 force-pushed the add-shortcuts-inhibit branch from 5e10dce to ac93706 Compare October 21, 2023 20:23
@ammen99 ammen99 merged commit ada3a6b into master Oct 23, 2023
8 checks passed
@ammen99 ammen99 deleted the add-shortcuts-inhibit branch October 23, 2023 12:11
@lilydjwg
Copy link
Contributor

It works fine, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for keyboard shortcuts inhibit
2 participants