Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabplay~ implementation broken #100

Closed
dromer opened this issue Mar 15, 2023 · 1 comment · Fixed by #101
Closed

tabplay~ implementation broken #100

dromer opened this issue Mar 15, 2023 · 1 comment · Fixed by #101
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@dromer
Copy link
Collaborator

dromer commented Mar 15, 2023

It's giving recursion errors, which is because the current heavy abstraction contains another tabplay~ ...

This abstraction seems to not be complete, which means it will need some work to properly implement and verify.
@dromer dromer mentioned this issue Mar 16, 2023
Merged
3 tasks
@dromer dromer added bug Something isn't working help wanted Extra attention is needed labels Mar 30, 2023
@dromer
Copy link
Collaborator Author

dromer commented Jul 25, 2023

We are very close to having a functional tabplay~ -> #101

Only thing missing is the bang on end of table.

It will of course need some testing/verification + making sure existing SignalTabread operations still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Missing vanilla objects
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement tabplay~ Wasted-Audio/hvcc
1 participant
@dromer