Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with v1.05 #16

Open
NarryG opened this issue Aug 22, 2017 · 9 comments
Open

Doesn't work with v1.05 #16

NarryG opened this issue Aug 22, 2017 · 9 comments

Comments

@NarryG
Copy link

NarryG commented Aug 22, 2017

The new update just came out and underdecomp fails to decompile the data.win

Unhandled Exception: System.Exception: String not zero terminated
   at GameMaker.BinaryReaderExtensions.ReadZeroTerminatedString(BinaryReader r) in C:\Users\Daniel\Downloads\GMdsam-master\GMdsam-master\GMdsam\GameMaker\Resources.cs:line 162
   at GameMaker.BinaryReaderExtensions.ReadStringFromOffset(BinaryReader r, Int32 offset) in C:\Users\Daniel\Downloads\GMdsam-master\GMdsam-master\GMdsam\GameMaker\Resources.cs:line 139
   at GameMaker.BinaryReaderExtensions.ReadStringFromNextOffset(BinaryReader r) in C:\Users\Daniel\Downloads\GMdsam-master\GMdsam-master\GMdsam\GameMaker\Resources.cs:line 132
   at GameMaker.File.Font.InternalRead(BinaryReader r) in C:\Users\Daniel\Downloads\GMdsam-master\GMdsam-master\GMdsam\GameMaker\ChunkTypes.cs:line 986
   at GameMaker.File.GameMakerStructure.Read(BinaryReader r, Int32 index) in C:\Users\Daniel\Downloads\GMdsam-master\GMdsam-master\GMdsam\GameMaker\ChunkTypes.cs:line 89
   at GameMaker.File.ReadList[T](List`1 list, BinaryReader r, Int32 start, Int32 end) in C:\Users\Daniel\Downloads\GMdsam-master\GMdsam-master\GMdsam\GameMaker\Resources.cs:line 864
   at GameMaker.File.CheckList[T](String chunkName, List`1& list) in C:\Users\Daniel\Downloads\GMdsam-master\GMdsam-master\GMdsam\GameMaker\Resources.cs:line 854
   at GameMaker.File.LoadEveything() in C:\Users\Daniel\Downloads\GMdsam-master\GMdsam-master\GMdsam\GameMaker\Resources.cs:line 821
   at GameM```
@theclashingfritz
Copy link

This is probably because 1.5 uses a newer Game Maker by chance.

@colinator27
Copy link

I got it to work with few modifications. Then I had to disable a bunch of error (Debug.Assert) messages to be able to decompile everything.

@NarryG
Copy link
Author

NarryG commented Aug 23, 2017

Could you post a build or the source by any chance?

@colinator27
Copy link

(replied to danne2 via Reddit)

@tsudou
Copy link

tsudou commented Aug 28, 2017

if you don't mind, could you send me a build or the source, too...? I managed to extract sprites and strings, but couldn't do other stuffs...

@colinator27
Copy link

@tsudou
Copy link

tsudou commented Aug 28, 2017

Thank you so much!! It seemed there might be something wrong because I got a lot of errors and warnings...? However, I could get all what I wanted!!

@WarlockD
Copy link
Owner

Sorry I had NO idea there was a new version. Freaking 1.5. I will take a look and patch it in. I never fixed the case detection code so I might just convert it to a bit train of if statements just so the ast works. As for the byte code it looks like its still using the newish code. Sigh. To many projects.

@WarlockD
Copy link
Owner

Could you put in a pull for the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants