Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow minor/patch version updates for web3-provider-engine? #892

Closed
brianlenz opened this issue Mar 30, 2022 · 2 comments
Closed

Allow minor/patch version updates for web3-provider-engine? #892

brianlenz opened this issue Mar 30, 2022 · 2 comments

Comments

@brianlenz
Copy link

Is there are reason web3-provider-engine needs to be fixed at 16.0.1 without allowing minor/patch version updates?

https://github.com/WalletConnect/walletconnect-monorepo/blob/v1.0/packages/providers/web3-provider/package.json#L71

It would be great if this used ^16.0.1 so that security updates can be applied. For example, there is currently a security vulnerability in web3-provider-engine:

GHSA-r683-j2x4-v87g

Ideally, web3-provider-engine will push an update to address this:

MetaMask/web3-provider-engine#401
MetaMask/web3-provider-engine#404

Without allowing at least patch updates to web3-provider-engine, the security vulnerability can't be mitigated, even once it's addressed in the underlying library.

@finessevanes
Copy link
Contributor

@brianlenz is this still an issue?

@brianlenz
Copy link
Author

@finessevanes, honestly, I'm not sure. I can see that the v1.0 link referenced above still has the issue, but it looks like the repository changed pretty dramatically in v2.0 (which I've not used), so I can't comment on whether it's an issue there or not...

@finessevanes finessevanes closed this as not planned Won't fix, can't repro, duplicate, stale Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants