From 88def33a9bc0389871bcd55a83d6e4331d1b2d48 Mon Sep 17 00:00:00 2001 From: Jan Monschke Date: Wed, 5 Oct 2022 14:26:49 +0200 Subject: [PATCH] [SecuritySolution] Link to the correct subscription upgrade "page/flow" (#142630) * fix: link to the correct subscription upgrade "page/flow" * test: fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .../event_details/insights/insights.test.tsx | 6 ++--- .../insights/related_alerts_upsell.tsx | 23 +++++++++++-------- .../event_details/insights/translations.ts | 4 ++-- 3 files changed, 19 insertions(+), 14 deletions(-) diff --git a/x-pack/plugins/security_solution/public/common/components/event_details/insights/insights.test.tsx b/x-pack/plugins/security_solution/public/common/components/event_details/insights/insights.test.tsx index b31cf1d1252bc..5ab2a172bc6e1 100644 --- a/x-pack/plugins/security_solution/public/common/components/event_details/insights/insights.test.tsx +++ b/x-pack/plugins/security_solution/public/common/components/event_details/insights/insights.test.tsx @@ -146,7 +146,7 @@ describe('Insights', () => { expect(screen.getByTestId('related-alerts-by-ancestry')).toBeInTheDocument(); expect( - screen.queryByRole('link', { name: new RegExp(i18n.ALERT_UPSELL) }) + screen.queryByRole('button', { name: new RegExp(i18n.INSIGHTS_UPSELL) }) ).not.toBeInTheDocument(); }); @@ -179,7 +179,7 @@ describe('Insights', () => { ); expect( - screen.getByRole('link', { name: new RegExp(i18n.ALERT_UPSELL) }) + screen.getByRole('button', { name: new RegExp(i18n.INSIGHTS_UPSELL) }) ).toBeInTheDocument(); expect(screen.queryByTestId('related-alerts-by-ancestry')).not.toBeInTheDocument(); }); @@ -198,7 +198,7 @@ describe('Insights', () => { expect(screen.queryByTestId('related-alerts-by-ancestry')).not.toBeInTheDocument(); expect( - screen.queryByRole('link', { name: new RegExp(i18n.ALERT_UPSELL) }) + screen.queryByRole('button', { name: new RegExp(i18n.INSIGHTS_UPSELL) }) ).not.toBeInTheDocument(); }); }); diff --git a/x-pack/plugins/security_solution/public/common/components/event_details/insights/related_alerts_upsell.tsx b/x-pack/plugins/security_solution/public/common/components/event_details/insights/related_alerts_upsell.tsx index 37ac07e3c03d0..ba225495a032b 100644 --- a/x-pack/plugins/security_solution/public/common/components/event_details/insights/related_alerts_upsell.tsx +++ b/x-pack/plugins/security_solution/public/common/components/event_details/insights/related_alerts_upsell.tsx @@ -5,11 +5,12 @@ * 2.0. */ -import React from 'react'; +import React, { useCallback } from 'react'; import { EuiFlexGroup, EuiFlexItem, EuiLink, EuiIcon, EuiText } from '@elastic/eui'; import { euiStyled } from '@kbn/kibana-react-plugin/common'; -import { ALERT_UPSELL } from './translations'; +import { INSIGHTS_UPSELL } from './translations'; +import { useNavigation } from '../../../lib/kibana'; const UpsellContainer = euiStyled.div` border: 1px solid ${({ theme }) => theme.eui.euiColorLightShade}; @@ -22,6 +23,15 @@ const StyledIcon = euiStyled(EuiIcon)` `; export const RelatedAlertsUpsell = React.memo(() => { + const { getAppUrl, navigateTo } = useNavigation(); + const subscriptionUrl = getAppUrl({ + appId: 'management', + path: 'stack/license_management', + }); + const goToSubscription = useCallback(() => { + navigateTo({ url: subscriptionUrl }); + }, [navigateTo, subscriptionUrl]); + return ( @@ -30,13 +40,8 @@ export const RelatedAlertsUpsell = React.memo(() => { - - {ALERT_UPSELL} + + {INSIGHTS_UPSELL} diff --git a/x-pack/plugins/security_solution/public/common/components/event_details/insights/translations.ts b/x-pack/plugins/security_solution/public/common/components/event_details/insights/translations.ts index e839003e1f7f9..10d9efca4682d 100644 --- a/x-pack/plugins/security_solution/public/common/components/event_details/insights/translations.ts +++ b/x-pack/plugins/security_solution/public/common/components/event_details/insights/translations.ts @@ -136,9 +136,9 @@ export const SIMPLE_ALERT_TABLE_LIMITED = i18n.translate( } ); -export const ALERT_UPSELL = i18n.translate( +export const INSIGHTS_UPSELL = i18n.translate( 'xpack.securitySolution.alertDetails.overview.insights.alertUpsellTitle', { - defaultMessage: 'Get more insights with a subscription', + defaultMessage: 'Get more insights with a platinum subscription', } );