You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
I found an error when showing the report while sniffing. I am not sure how are you bundling the sniffer in the plugin (manually?) I didn't look that much in the code, but it seems to me that the full report file is missing (on line 182 in \Reports\Full.php)
I tried to make a PR to the phpcs, but the author explained that this is a human readable format and that it should remain that way, and that the better course of action would be to use
JSON, XML or CSV report types and then display the output however you want.
The reason for this issue is that the report, as it currently is, will render the HTML elements in the report. For instance (on the left is the plugin, on the right the report I manually made with phpcs):
When corrected would be
I tried adding htmlspecialchars in the helpers.php of the plugin but that didn't work. You could change the report to JSON, then parse it and show it I guess, don't know how much time that would take. Or, if you are manually placing codesniffer in you can modify the file I did, even though this will only create issues if you need to update the code sniffer periodically.
The text was updated successfully, but these errors were encountered:
I found an error when showing the report while sniffing. I am not sure how are you bundling the sniffer in the plugin (manually?) I didn't look that much in the code, but it seems to me that the full report file is missing (on line 182 in
\Reports\Full.php
)I tried to make a PR to the phpcs, but the author explained that this is a human readable format and that it should remain that way, and that the better course of action would be to use
The reason for this issue is that the report, as it currently is, will render the HTML elements in the report. For instance (on the left is the plugin, on the right the report I manually made with phpcs):
When corrected would be
I tried adding
htmlspecialchars
in thehelpers.php
of the plugin but that didn't work. You could change the report to JSON, then parse it and show it I guess, don't know how much time that would take. Or, if you are manually placing codesniffer in you can modify the file I did, even though this will only create issues if you need to update the code sniffer periodically.The text was updated successfully, but these errors were encountered: