Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Idea for update - choose standard #2

Closed
dingo-d opened this issue Jan 20, 2017 · 6 comments
Closed

Idea for update - choose standard #2

dingo-d opened this issue Jan 20, 2017 · 6 comments

Comments

@dingo-d
Copy link
Member

dingo-d commented Jan 20, 2017

It would be cool to add the option with which standard to sniff the theme - Core, Theme, VIP etc. Kinda like:

suggestion_sniffs

@ernilambar
Copy link
Member

ernilambar commented Jan 20, 2017

It is great option to have. But in the context of TRT, it is not suitable to add that dropdown because we will always be using WordPress Theme standard.

@dingo-d
Copy link
Member Author

dingo-d commented Jan 20, 2017

Yes, for TRT it's not necessary, but in general it could be a great addition :)

@grappler
Copy link
Member

I think it would be a good idea. We would just need to be clear that WordPress-Theme is the main one.

Instead of having to run the sniff multiple times, I think a checkbox might be better than a dropdown. This way you can choose which rulesets you want to run.

As "NS Theme Check" will not be the official plugin it would be nice to test a few ideas and see what feedback people give.

This would be for a separate issue but we are seeing people struggle with the difference between Errors and Warnings.

@ernilambar
Copy link
Member

ernilambar commented Feb 9, 2017

Instead of having to run the sniff multiple times, I think a checkbox might be better than a dropdown. This way you can choose which rulesets you want to run.

@grappler Is it possible to set multiple standard? Can you please point me how we can implement this? :-)

@grappler
Copy link
Member

grappler commented Feb 9, 2017

Is it possible to set multiple standard?

Yes

Can you please point me how we can implement this?

Sure phpcs --standard=WordPress-Theme,WordPress-Core or $values['standard'] = 'WordPress-Theme,WordPress-Core';

@ernilambar
Copy link
Member

Fixed in #11

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants