Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

kirki outputted twice for textdomain sniff error message #108

Closed
timelsass opened this issue Mar 1, 2019 · 2 comments
Closed

kirki outputted twice for textdomain sniff error message #108

timelsass opened this issue Mar 1, 2019 · 2 comments
Assignees
Labels
Type: Bug There is a bug in the plugin.

Comments

@timelsass
Copy link
Member

image

@dingo-d dingo-d self-assigned this Mar 1, 2019
@dingo-d dingo-d added Type: Bug There is a bug in the plugin. issue: has PR labels Mar 1, 2019
@dingo-d
Copy link
Member

dingo-d commented Mar 1, 2019

Hmm interesting bug. Can you provide the theme that caused it? Easier to test it.

@timelsass
Copy link
Member Author

timelsass commented Mar 1, 2019

Hey it was caused because the depth of 4 in the php files loop. I had a folder with a few classes like "class-themename-extend-kirki-typography.php", "class-themename-extend-kirki-palette.php". The loop just kept appending kirki for found matches without checking if it existed in the array of text domains already.

I pushed up some changes for that, and a few optimizations to help reduce some of the overhead of the file search that was in there.

@dingo-d dingo-d closed this as completed in c91fca3 Mar 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug There is a bug in the plugin.
Projects
None yet
Development

No branches or pull requests

2 participants