From 31674d4c6fb1fb315ad7f1ead3a358fad131517b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Denis=20=C5=BDoljom?= <denis.zoljom@gmail.com> Date: Sat, 18 May 2019 14:14:23 +0200 Subject: [PATCH 1/2] Add deprecated parameter values rule in the ruleset --- WPThemeReview/ruleset.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/WPThemeReview/ruleset.xml b/WPThemeReview/ruleset.xml index d1b0e3ba..875cb99f 100644 --- a/WPThemeReview/ruleset.xml +++ b/WPThemeReview/ruleset.xml @@ -159,4 +159,6 @@ <!-- Themes should never touch the timezone. --> <rule ref="WordPress.WP.TimezoneChange"/> + <!-- Check for usage of deprecated parameter values in WP functions and provide alternative based on the parameter passed. --> + <rule ref="WordPress.WP.DeprecatedParameterValues"/> </ruleset> From d13f2c4025ca9dc326dc208123eec878bdae38ce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Denis=20=C5=BDoljom?= <denis.zoljom@gmail.com> Date: Mon, 20 May 2019 11:28:13 +0200 Subject: [PATCH 2/2] Move the sniff to the deprecated block in the ruleset --- WPThemeReview/ruleset.xml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/WPThemeReview/ruleset.xml b/WPThemeReview/ruleset.xml index 875cb99f..55a047bc 100644 --- a/WPThemeReview/ruleset.xml +++ b/WPThemeReview/ruleset.xml @@ -124,6 +124,9 @@ <type>error</type> </rule> + <!-- Check for usage of deprecated parameter values in WP functions and provide alternative based on the parameter passed. --> + <rule ref="WordPress.WP.DeprecatedParameterValues"/> + <!-- Verify that everything in the global namespace is prefixed. --> <!-- Covers: https://make.wordpress.org/themes/handbook/review/required/#code - last bullet. --> <!-- NOTE: this sniff needs a custom property to be set for it to be activated. --> @@ -159,6 +162,4 @@ <!-- Themes should never touch the timezone. --> <rule ref="WordPress.WP.TimezoneChange"/> - <!-- Check for usage of deprecated parameter values in WP functions and provide alternative based on the parameter passed. --> - <rule ref="WordPress.WP.DeprecatedParameterValues"/> </ruleset>