Usage of CRON functions in theme

[dingo-d]

We were going through the upstream sniffs during the meeting, especially through CronIntervalSniff, and we don't know whether to use it or not, because we don't have an agreement if we should allow cron jobs inside themes at all.

So a discussion is needed on this prefferably in the WPTRT meeting.

[justintadlock]

Cron jobs are plugin territory and not currently allowed in themes.

[dingo-d]

@jrfnl Feel free to exclude this sniff then :)

[jrfnl]

Feel free to exclude this sniff then :)

Well, we just won't be adding the sniff.

However, this does raise another question: should there be a sniff that prohibits adding/touching cron ?
As in, a sniff which checks for cron jobs being added/altered/removed ?

[grappler]

As in, a sniff which checks for cron jobs being added/altered/removed ?

Yes, I think that would make sense as theme should not be running regular tasks.

[justintadlock]

Team discussed this. Can this be combined with an existing sniff for disallowed functions? If that's the best route, take it. Otherwise, implement a specific sniff for this.

Meeting: https://wordpress.slack.com/archives/C02RP4Y3K/p1528822802001090

[jrfnl]

Thanks for the update. There will be one or more sniffs which will disallow functions, this is not included yet, but being worked on. If all that needs forbidding is functions, this will be included when I pull it.

Are there any cron hooks which should be forbidden too ?

[dingo-d]

We didn't mention specific hooks, but in general, all cron meddling in the theme should be forbidden.

[joyously]

Functions to disallow?
wp_schedule_event
wp_unschedule_hook
wp_reschedule_event
wp_unschedule_event
wp_clear_scheduled_hook
wp_schedule_single_event
wp_schedule_update_checks
wp_schedule_update_network_counts
wp_cron

[dingo-d]

Should this be in the ForbiddenFunctionsSniff or should I create a new sniff DisallowCRONUsageSniff ? Because it seems to me like cron is a plugin territory, and if this is correct, I can add those to the #215 PR 🙂

[dingo-d]

This has been merged in the develop branch and will be released with 0.2.0.