Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo of inserting Context Box removes linked actor #85

Closed
nilsbert opened this issue Sep 17, 2020 · 2 comments
Closed

Undo of inserting Context Box removes linked actor #85

nilsbert opened this issue Sep 17, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@nilsbert
Copy link

Describe the bug
Undo of inserting Context Box removes linked actor.

To Reproduce

  1. Insert icon "mobile phone"
  2. Insert icon actor
  3. Link mobile phone to actor
  4. Repeat it for other element -> Screenshot
  5. Draw context box fully over linked elements
  6. Undo -> Strg Z
  7. Box and some icons are removed

Expected behavior
Only box removed

Screenshots
Bildschirmfoto 2020-09-17 um 10 54 13

Bildschirmfoto 2020-09-17 um 10 55 05

Command-Z

Bildschirmfoto 2020-09-17 um 10 55 10

[If applicable, add screenshots to help explain your problem.]

Desktop + Browser:
MacOs: 10.15.6
Chrome: Version 85.0.4183.102 (Offizieller Build) (64-Bit)
@hofstef
Copy link
Member

hofstef commented Oct 13, 2020

Hi, if I follow your steps, I cannot reproduce the problem (Modeler v1.1.1). However, I noticed that your screenshots do not match the steps you described. Could you please check if the steps that you provided are describing the incorrect behavour? Thanks!

@AlexanderZellober AlexanderZellober added the bug Something isn't working label Nov 19, 2020
AlexanderZellober added a commit that referenced this issue Nov 19, 2020
@AlexanderZellober
#85 fixes undo of adding groups
0c69f15 
sinde the allocation of child-elements to the group is its own step, there is an additional undo needed
@hofstef hofstef closed this as completed Mar 9, 2021
@hofstef
Copy link
Member

hofstef commented Mar 9, 2021

fixed in v1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nilsbert @hofstef @AlexanderZellober