Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use outline icons instead of solid icons in palette and context pad #2

Closed
hofstef opened this issue Sep 19, 2018 · 2 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@hofstef
Copy link
Member

hofstef commented Sep 19, 2018

The modeler uses the outline version of Google's Material icons,. However, in the context pad and in the palette, solid icons are used instead.
The icons should be unified. Outline is the style of choice because it is more printer friendly.

@hofstef hofstef added the bug Something isn't working label Sep 19, 2018
@hofstef hofstef added this to the 1.0.0 milestone Nov 26, 2018
@hofstef
Copy link
Member Author

hofstef commented Dec 19, 2018

The icons for the palette and the context pad are defined in a font file that only contains solid icons. Google has not updated the font in years.
Alternatives:

  • an alternative icon set that comes with a font (fontawesome?)
  • make our own font with the icons that we need
  • use svg instead of fonts; however, this breakes highlighting in the context pad.

@AlexanderZellober
Copy link
Member

Found a way to use svg that does not break highlighting in the contextPad.

AlexanderZellober added a commit that referenced this issue Apr 15, 2019
…own as outline and icons are consitent with the way, custom-icons are appended to the style-sheet #2
@hofstef hofstef closed this as completed May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants