Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: washingtonpost/wpds-ui-kit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.4.5
Choose a base ref
...
head repository: washingtonpost/wpds-ui-kit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.5.0
Choose a head ref
  • 4 commits
  • 33 files changed
  • 2 contributors

Commits on Mar 7, 2022

  1. Copy the full SHA
    dc264f0 View commit details
  2. fix: checkbox bug with stitches props

    basically we cant name variants the same as react component props or controlled atttributes
    artmsilva committed Mar 7, 2022
    Copy the full SHA
    d1e510d View commit details
  3. 1
    Copy the full SHA
    e908a91 View commit details
  4. chore(release): publish

    site-eng-github-actions committed Mar 7, 2022
    1
    Copy the full SHA
    3b12dd3 View commit details
17 changes: 17 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,23 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [0.5.0](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.5...v0.5.0) (2022-03-07)


### Bug Fixes

* checkbox bug with stitches props ([d1e510d](https://github.com/WPMedia/wpds-ui-kit/commit/d1e510d565e35b341de432911fc304c23728a33b))
* disabled checkbox states ([e908a91](https://github.com/WPMedia/wpds-ui-kit/commit/e908a91f0c6f01d69022b209b1dd0ccc32da422d))


### Features

* support fill attribute ([dc264f0](https://github.com/WPMedia/wpds-ui-kit/commit/dc264f0ade0fdc46475f07745c5f6406a0be0d1b))





## [0.4.5](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.4...v0.4.5) (2022-03-04)

**Note:** Version bump only for package root
11 changes: 11 additions & 0 deletions app/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [0.5.0](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.5...v0.5.0) (2022-03-07)


### Bug Fixes

* checkbox bug with stitches props ([d1e510d](https://github.com/WPMedia/wpds-ui-kit/commit/d1e510d565e35b341de432911fc304c23728a33b))





## [0.4.5](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.4...v0.4.5) (2022-03-04)

**Note:** Version bump only for package app
7 changes: 4 additions & 3 deletions app/package.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
{
"name": "app",
"version": "0.4.5",
"version": "0.5.0",
"private": true,
"description": "",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"build": "next build",
"dev": "next dev"
"dev": "next dev",
"clean": "rm -rf .turbo && rm -rf node_modules && rm -rf .next"
},
"author": "",
"license": "ISC",
"dependencies": {
"@next/bundle-analyzer": "^12.0.7",
"@washingtonpost/wpds-assets": "^1.2.1",
"@washingtonpost/wpds-ui-kit": "0.4.5",
"@washingtonpost/wpds-ui-kit": "0.5.0",
"next": "^12.0.4",
"react": "^17.0.2",
"react-dom": "^17.0.2"
16 changes: 8 additions & 8 deletions app/pages/index.tsx
Original file line number Diff line number Diff line change
@@ -93,20 +93,20 @@ function HomePage() {
<HStack>
<>
<HStack>
<Checkbox defaultChecked checked variant="primary" size="125" />
<Checkbox defaultChecked checked variant="secondary" />
<Checkbox defaultChecked checked variant="cta" />
<Checkbox checked variant="primary" size="125" />
<Checkbox checked variant="secondary" />
<Checkbox checked variant="cta" />
</HStack>
<HStack>
<Checkbox defaultChecked checked size="087" />
<Checkbox defaultChecked checked size="125" />
<Checkbox checked size="087" />
<Checkbox checked size="125" />
</HStack>
<HStack>
<Checkbox defaultChecked checked />
<Checkbox defaultChecked checked isOutline />
<Checkbox checked />
<Checkbox checked isOutline />
</HStack>
<HStack>
<Checkbox defaultChecked checked />
<Checkbox checked />
<Checkbox checked={false} />
<Checkbox checked="indeterminate" />
</HStack>
4 changes: 4 additions & 0 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -34,16 +34,20 @@ npm run storybook
npm run playroom:start
```

You can run `npm run dev` to develop and test with the test app.

## Testing

We use Testing Library and/or Storybook's new Interaction feature for Unit & Interaction Testing

This command runs the Jest.

```shell
npm run test
```

This command runs the Storybook Test runner

```shell
npm run test-storybook
```
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
@@ -32,5 +32,5 @@
"registry": "https://registry.npmjs.org/"
}
},
"version": "0.4.5"
"version": "0.5.0"
}
4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -101,7 +101,9 @@
"postinstall": "npm run bootstrap",
"new-component": "make new-component",
"lint": "eslint --ext .ts,.tsx ui/",
"test-storybook": "test-storybook"
"test-storybook": "test-storybook",
"dev": "turbo run dev --no-cache --parallel --continue",
"clean": "turbo run clean && rm -rf node_modules"
},
"engines": {
"yarn": "yarn NO LONGER USED - use npm instead.",
6 changes: 4 additions & 2 deletions plop-templates/component/package.json.hbs
Original file line number Diff line number Diff line change
@@ -24,7 +24,9 @@
},
"scripts": {
"test": "echo \"Error: run tests from root\" && exit 1",
"build": "npx tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react"
"build": "tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react",
"dev": "tsup src/index.ts --format esm,cjs --watch --dts --legacy-output --external react",
"clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist"
},
"bugs": {
"url": "https://github.com/WPMedia/wpds-ui-kit/issues"
@@ -35,6 +37,6 @@
},
"peerDependencies": {
"@washingtonpost/wpds-theme": "*",
"react": "^16.8.6 || ^17.0.2",
"react": "^16.8.6 || ^17.0.2",
},
}
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
"baseUrl": ".",
"paths": {
"*": ["node_modules/*"],
"app": ["./app/*"],
"@washingtonpost/wpds-ui-kit": ["./ui/kit/src/*"],
"@washingtonpost/wpds-container": ["./ui/container/src/*"],
"@washingtonpost/wpds-box": ["./ui/box/src/*"],
6 changes: 6 additions & 0 deletions turbo.json
Original file line number Diff line number Diff line change
@@ -9,6 +9,12 @@
"validate": {
"dependsOn": ["build"],
"outputs": [""]
},
"dev": {
"cache": false
},
"clean": {
"cache": false
}
}
}
11 changes: 11 additions & 0 deletions ui/alert-banner/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [0.5.0](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.5...v0.5.0) (2022-03-07)


### Bug Fixes

* checkbox bug with stitches props ([d1e510d](https://github.com/WPMedia/wpds-ui-kit/commit/d1e510d565e35b341de432911fc304c23728a33b))





## [0.4.5](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.4...v0.4.5) (2022-03-04)

**Note:** Version bump only for package @washingtonpost/wpds-alert-banner
6 changes: 4 additions & 2 deletions ui/alert-banner/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@washingtonpost/wpds-alert-banner",
"version": "0.4.5",
"version": "0.5.0",
"description": "WPDS Alert Banner",
"author": "WPDS Support <wpds@washpost.com>",
"homepage": "https://github.com/WPMedia/wpds-ui-kit#readme",
@@ -24,7 +24,9 @@
},
"scripts": {
"test": "echo \"Error: run tests from root\" && exit 1",
"build": "npx tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react --clean"
"build": "tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react --clean",
"dev": "tsup src/index.ts --format esm,cjs --watch --dts --legacy-output --external react",
"clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist"
},
"bugs": {
"url": "https://github.com/WPMedia/wpds-ui-kit/issues"
11 changes: 11 additions & 0 deletions ui/app-bar/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [0.5.0](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.5...v0.5.0) (2022-03-07)


### Bug Fixes

* checkbox bug with stitches props ([d1e510d](https://github.com/WPMedia/wpds-ui-kit/commit/d1e510d565e35b341de432911fc304c23728a33b))





## [0.4.5](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.4...v0.4.5) (2022-03-04)

**Note:** Version bump only for package @washingtonpost/wpds-app-bar
6 changes: 4 additions & 2 deletions ui/app-bar/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@washingtonpost/wpds-app-bar",
"version": "0.4.5",
"version": "0.5.0",
"description": "WPDS App Bar",
"author": "WPDS Support <wpds@washpost.com>",
"homepage": "https://github.com/WPMedia/wpds-ui-kit#readme",
@@ -24,7 +24,9 @@
},
"scripts": {
"test": "echo \"Error: run tests from root\" && exit 1",
"build": "npx tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react --clean"
"build": "tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react --clean",
"dev": "tsup src/index.ts --format esm,cjs --watch --dts --legacy-output --external react",
"clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist"
},
"bugs": {
"url": "https://github.com/WPMedia/wpds-ui-kit/issues"
11 changes: 11 additions & 0 deletions ui/box/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [0.5.0](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.5...v0.5.0) (2022-03-07)


### Bug Fixes

* checkbox bug with stitches props ([d1e510d](https://github.com/WPMedia/wpds-ui-kit/commit/d1e510d565e35b341de432911fc304c23728a33b))





## [0.4.5](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.4...v0.4.5) (2022-03-04)

**Note:** Version bump only for package @washingtonpost/wpds-box
6 changes: 4 additions & 2 deletions ui/box/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@washingtonpost/wpds-box",
"version": "0.4.5",
"version": "0.5.0",
"description": "WPDS Box component",
"author": "WPDS Support <wpds@washpost.com>",
"homepage": "https://github.com/WPMedia/wpds-ui-kit#readme",
@@ -24,7 +24,9 @@
},
"scripts": {
"test": "echo \"Error: run tests from root\" && exit 1",
"build": "npx tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react --clean"
"build": "tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react --clean",
"dev": "tsup src/index.ts --format esm,cjs --watch --dts --legacy-output --external react",
"clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist"
},
"bugs": {
"url": "https://github.com/WPMedia/wpds-ui-kit/issues"
11 changes: 11 additions & 0 deletions ui/button/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [0.5.0](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.5...v0.5.0) (2022-03-07)


### Bug Fixes

* checkbox bug with stitches props ([d1e510d](https://github.com/WPMedia/wpds-ui-kit/commit/d1e510d565e35b341de432911fc304c23728a33b))





## [0.4.5](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.4...v0.4.5) (2022-03-04)

**Note:** Version bump only for package @washingtonpost/wpds-button
6 changes: 4 additions & 2 deletions ui/button/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@washingtonpost/wpds-button",
"version": "0.4.5",
"version": "0.5.0",
"description": "WPDS Button",
"author": "WPDS Support <wpds@washpost.com>",
"homepage": "https://github.com/WPMedia/wpds-ui-kit#readme",
@@ -24,7 +24,9 @@
},
"scripts": {
"test": "echo \"Error: run tests from root\" && exit 1",
"build": "npx tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react --clean"
"build": "tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react --clean",
"dev": "tsup src/index.ts --format esm,cjs --watch --dts --legacy-output --external react",
"clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist"
},
"bugs": {
"url": "https://github.com/WPMedia/wpds-ui-kit/issues"
12 changes: 12 additions & 0 deletions ui/checkbox/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -3,6 +3,18 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [0.5.0](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.5...v0.5.0) (2022-03-07)


### Bug Fixes

* checkbox bug with stitches props ([d1e510d](https://github.com/WPMedia/wpds-ui-kit/commit/d1e510d565e35b341de432911fc304c23728a33b))
* disabled checkbox states ([e908a91](https://github.com/WPMedia/wpds-ui-kit/commit/e908a91f0c6f01d69022b209b1dd0ccc32da422d))





## [0.4.5](https://github.com/WPMedia/wpds-ui-kit/compare/v0.4.4...v0.4.5) (2022-03-04)

**Note:** Version bump only for package @washingtonpost/wpds-checkbox
6 changes: 4 additions & 2 deletions ui/checkbox/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@washingtonpost/wpds-checkbox",
"version": "0.4.5",
"version": "0.5.0",
"description": "WPDS Checkbox",
"author": "WPDS Support <wpds@washpost.com>",
"homepage": "https://github.com/WPMedia/wpds-ui-kit#readme",
@@ -24,7 +24,9 @@
},
"scripts": {
"test": "echo \"Error: run tests from root\" && exit 1",
"build": "npx tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react --clean"
"build": "tsup src/index.ts --loader .ts=tsx --minify --format esm,cjs --dts --sourcemap --legacy-output --external react --clean",
"dev": "tsup src/index.ts --format esm,cjs --watch --dts --legacy-output --external react",
"clean": "rm -rf .turbo && rm -rf node_modules && rm -rf dist"
},
"bugs": {
"url": "https://github.com/WPMedia/wpds-ui-kit/issues"
Loading