Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(PeerGroup): Pass in domain objects to Controller method params #98

Closed
hirokiterashima opened this issue Feb 15, 2022 · 1 comment
Closed

refactor(PeerGroup): Pass in domain objects to Controller method params #98

hirokiterashima opened this issue Feb 15, 2022 · 1 comment
Assignees
@hirokiterashima

Comments

@hirokiterashima
Copy link
Member

Description

Use Spring's DomainClassConverter so we don't need to pass in [runId/projectId/workgroupId...] and look it up using [Run/Project/Workgroup...]Service. Spring should automatically look it up using the [Run/Project/Workgroup...]Repository.

  • PeerGoupAPIController
    • getPeerGroup
  • PeerGoupWorkAPIController
    • getPeerGroupWork
  • PeerGroupWorkController
    • getPeerGroupWork
@hirokiterashima hirokiterashima self-assigned this Feb 15, 2022
@hirokiterashima hirokiterashima mentioned this issue Feb 15, 2022
Merged
@hirokiterashima hirokiterashima moved this from Todo to Under Review in WISE Development Feb 16, 2022
@hirokiterashima
Copy link
Member Author

Closed by #99

Repository owner moved this from Under Review to Done in WISE Development Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirokiterashima hirokiterashima

Labels
None yet
Projects
WISE Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hirokiterashima