Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Teacher can't open grading tool #68

Closed
hirokiterashima opened this issue Nov 30, 2021 · 2 comments · Fixed by #69
Closed

Bug: Teacher can't open grading tool #68

hirokiterashima opened this issue Nov 30, 2021 · 2 comments · Fixed by #69
Assignees
@hirokiterashima
Labels
1 point High Priority released

Comments

@hirokiterashima
Copy link
Member

Description

When a teacher (not a shared teacher or admin) goes to open a grading tool for a run that they own, they see a blank screen.

The culprit is this method returns false due to changes made in this PR

  private Boolean isTeacherAssociatedWithRun(Run run, User user) {
    return (user.isTeacher() && run.isTeacherAssociatedToThisRun(user)) || user.isAdmin();
  }

The user object is now HibernateProxy object and run.isTeacherAssociatedToThisRun(user) returns false.
@hirokiterashima hirokiterashima self-assigned this Nov 30, 2021
@hirokiterashima hirokiterashima moved this from Todo to In Progress in WISE Development Nov 30, 2021
@geoffreykwan geoffreykwan mentioned this issue Nov 30, 2021
Merged
@geoffreykwan
Copy link
Member

Fixed in #69

@geoffreykwan geoffreykwan moved this from In Progress to Done in WISE Development Nov 30, 2021
@geoffreykwan
Copy link
Member

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirokiterashima hirokiterashima

Labels
1 point High Priority released
Projects
WISE Development
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Grading Tool): Teacher can open grading tool WISE-Community/WISE-API
2 participants
@hirokiterashima @geoffreykwan