Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Password): Allow special characters in password #233

Merged
merged 3 commits into from
Oct 22, 2023
Merged

feat(Password): Allow special characters in password #233

merged 3 commits into from
Oct 22, 2023

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Sep 5, 2023 •
edited
Loading

Changes

  • Allow these symbols to be used in a password !@#$%^&*
  • Passwords now require a letter, number, symbol, and to be at least 8 characters (we no longer require uppercase letter but they may still be used)
  • Validate password and if there are errors, send back errors to client

Test

Closes #232

@geoffreykwan geoffreykwan self-assigned this Sep 5, 2023
@geoffreykwan geoffreykwan mentioned this pull request Sep 5, 2023
Merged
@geoffreykwan geoffreykwan marked this pull request as ready for review September 6, 2023 15:09
hirokiterashima
hirokiterashima approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffreykwan geoffreykwan merged commit a3f28b1 into develop Oct 22, 2023
@geoffreykwan geoffreykwan deleted the issue-232-allow-special-characters-in-password branch October 22, 2023 17:44
@geoffreykwan
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

breity pushed a commit to I-Sparkle-Germany/I-Sparkle-API that referenced this pull request Jan 10, 2024
@geoffreykwan @breity
feat(Password): Allow special characters in password (WISE-Community#233
7936856 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
released
Projects
WISE Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow a set of special characters in passwords
2 participants
@geoffreykwan @hirokiterashima