fix(UserRegistration): Allow spaces and - in first and last name #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffreykwan
requested changes
Nov 21, 2022
| @@ -165,7 +165,7 @@ public class TeacherUserDetails extends PersistentUserDetails implements Mutable | |||
| private String howDidYouHearAboutUs; | |||
|
|
|||
| public String getCoreUsername() { | |||
| return firstname + lastname; | |||
| return firstname.replaceAll("[\\s-]+", "") + lastname.replaceAll("[\\s-]+", ""); | |||
There was a problem hiding this comment.
I think we can change this to just call replaceAll once.
return (firstname + lastname).replaceAll("[\\s-]+", "");
ccwemett
changed the title
#183 # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # On branch issue-183-update-account-validation # Your branch is up to date with 'origin/issue-183-update-account-validation'. # # Changes to be committed: # modified: src/main/java/org/wise/portal/domain/authentication/impl/TeacherUserDetails.java #
breity
added a commit
to I-Sparkle-Germany/I-Sparkle-API
that referenced
this pull request
Dec 4, 2022
fix(UserRegistration): Allow spaces and - in first and last name (WISE-Community#192)
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Test
Closes #183