Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Password): Increase password validation requirements #178

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Sep 23, 2022

Test with

Changes

  • Increased server side password validation requirements to require at least 8 characters and at least one lowercase, one uppercase, and one number
  • Password change endpoints now return a ResponseEntity which allows us to specify the response status code such as 200 for ok or 400 for bad request as well as send additional custom information such as what type of error occurred

Test

  • Make sure the password change endpoints enforce the new password requirements
  • Make sure the password change endpoints send back an error response when an error occurs (they used to send back a success response but with error information)
  • Make sure the password change success response still works

Here are the places where users can specify passwords

  • student create account
  • student forgot password
  • teacher create account
  • teacher forgot password
  • teacher change student password in classroom monitor
  • user edit password
  • user unlink Google account

Closes #177

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@geoffreykwan geoffreykwan merged commit 49dafdb into develop Sep 27, 2022
@geoffreykwan geoffreykwan deleted the issue-177-increase-password-requirements branch September 27, 2022 16:23
@geoffreykwan
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Increase password requirements
2 participants