Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Session): Remove Session ID from Redis after logout #168

Conversation

hirokiterashima
Copy link
Member

Test

  • Login as teacher or user, and check Redis keys keys *. You should see an entry like this:
    spring:session:index:org.springframework.session.FindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME:username
  • Logout as the user and check Redis keys again. The entry should be deleted. Before, this entry was not getting deleted.

Closes #167

Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think we might need to run flushall after deploying this update.

  • I previously had the key
    "spring:session:index:org.springframework.session.FindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME:GK"
    in my local Redis
  • I applied the pull request change
  • I signed in as GK and then signed out
  • The key was still in my local Redis after I signed out
  • I ran flushall
  • I signed in as GK and it recreated the key
    "spring:session:index:org.springframework.session.FindByIndexNameSessionRepository.PRINCIPAL_NAME_INDEX_NAME:GK"
  • I signed out from GK and the key was then removed

@hirokiterashima hirokiterashima merged commit 51bd8e6 into develop Aug 2, 2022
@hirokiterashima hirokiterashima deleted the issue-167-remove-session-id-entry-from-redis-after-logout branch August 2, 2022 19:02
@geoffreykwan
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Session ID entry not being removed from Redis after logout
2 participants