Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom]: Need adopted callback (bugzilla: 24577) #210

Closed
hayatoito opened this issue Jul 6, 2015 · 4 comments
Closed

[Custom]: Need adopted callback (bugzilla: 24577) #210

hayatoito opened this issue Jul 6, 2015 · 4 comments

Comments

@hayatoito
Copy link
Contributor

Title: [Custom]: Need adopted callback (bugzilla: 24577)

Migrated from: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24577


comment: 0
comment_url: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24577#c0
Anne wrote on 2014-02-07 10:45:19 +0000.

See bug 20567 comment 69. We should have a callback for adoption so you can deal with moving to a new document and prevent leaking an entire global. The callback should take the old and new document as arguments.

See bug 24570 for the equivalent bug on cloning.


comment: 1
comment_url: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24577#c1
Anne wrote on 2014-02-10 10:54:39 +0000.

New document is not needed as argument since you can get the node's ownerDocument (its node document).


comment: 2
comment_url: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24577#c2
Anne wrote on 2014-02-10 11:13:20 +0000.

If you cannot model this after http://dom.spec.whatwg.org/#concept-node-adopt-ext please tell me.


comment: 3
comment_url: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24577#c3
Anne wrote on 2014-02-10 11:13:46 +0000.

Obviously that callback in the DOM will need to be made asynchronous. Will do that once there's a proper hook in IDL or some such.

@rniwa
Copy link
Collaborator

rniwa commented Mar 1, 2016

@annevk : Do you think we need this in v1?

@rniwa
Copy link
Collaborator

rniwa commented Mar 1, 2016

Also, should we close this issue in favor of the issue #176?

@annevk annevk added the v2 label Mar 1, 2016
@annevk
Copy link
Collaborator

annevk commented Mar 1, 2016

This is a distinct issue. Adoption is different from cloning. No rush though I think. There's still controvery around exactly what we should do for adoption and whether or not leaking globals is acceptable.

@annevk
Copy link
Collaborator

annevk commented Jul 21, 2016

This got fixed by #512.

@annevk annevk closed this as completed Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants