Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to layout containment instead of paint containment for shared elements #164

Closed
khushalsagar opened this issue Jun 28, 2022 · 1 comment

Comments

@khushalsagar
Copy link
Collaborator

The SET spec requires shared elements to have paint containment. This is necessary for 2 reasons:

  • So the elements generate a stacking context which makes it easier to capture their contents as an atomic screenshot.

  • So the elements are a containing block for all positioned descendants. This is necessary because during the transition they animate as an atomic unit.

Both of these should be possible with just layout containment so paint containment adds unnecessary additional constraints.

@vmpstr
Copy link
Collaborator

vmpstr commented Jul 21, 2022

Done.

@vmpstr vmpstr closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants