Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Additional bids and negative targeting feature #796

Merged
merged 41 commits into from
Oct 20, 2023
Merged

[Spec] Additional bids and negative targeting feature #796

Changes from 12 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
30a60ec
Spec for negative targeting.
Sep 8, 2023
aed21bd
Merge branch 'WICG:main' into negative
qingxinwu Sep 8, 2023
8437609
Merge branch 'WICG:main' into negative
qingxinwu Sep 11, 2023
cd8b7ff
Handling auction config for additional bids.
Sep 12, 2023
7df1d28
Merge branch 'WICG:main' into negative
qingxinwu Sep 12, 2023
dfd9f6f
progress
Sep 12, 2023
1960076
Rename pending promise count to scoring dependency count.
Sep 13, 2023
f0dd38f
Merge branch 'WICG:main' into negative
qingxinwu Sep 13, 2023
112ec49
Merge branch 'negative' of github.com:qingxinwu/turtledove into negative
Sep 13, 2023
4af1a81
Finish additional bids, including reporting.
Sep 18, 2023
66b9c27
Merge branch 'main' into negative
qingxinwu Sep 18, 2023
dd33c70
Finish negative targeting.
Sep 19, 2023
c662af8
Merge branch 'WICG:main' into negative
qingxinwu Sep 21, 2023
9b00edc
Address comments.
Sep 21, 2023
1a1b706
Fix promise handling issue.
Sep 25, 2023
7a6262b
Merge branch 'main' into negative
qingxinwu Sep 25, 2023
92c7620
Modify how addition bids promise is handled.
Sep 25, 2023
1b986d5
Require interest group buyers.
Sep 26, 2023
9e75f44
Address comments.
Sep 26, 2023
fdd749b
Address Maks's comments.
Sep 27, 2023
ca191db
Merge branch 'WICG:main' into negative
qingxinwu Sep 28, 2023
15f61df
Change to [=parse an https origin=]
Sep 28, 2023
4983934
Add a note: additional bid promise resolves after fetch finishes.
Sep 28, 2023
b862183
Address comments.
Sep 28, 2023
784a978
Check ig's ads being null.
Sep 29, 2023
ff2bc2a
Updated IG cannot have both ads and additional bid key.
Sep 29, 2023
7768133
fix build error.
Sep 29, 2023
3b83534
Negative IG cannot be updated.
Oct 2, 2023
50abe8c
Merge branch 'WICG:main' into negative
qingxinwu Oct 2, 2023
f33935a
Address Dom's comments.
Oct 9, 2023
05c2e9b
Merge branch 'WICG:main' into negative
qingxinwu Oct 9, 2023
24d642e
Merge branch 'main' into negative
qingxinwu Oct 12, 2023
524aa7a
Merge branch 'main' into negative
qingxinwu Oct 16, 2023
e65dff8
Add non-normative, and link to adAuctionHeaders.
Oct 17, 2023
baa13e3
Define Ad-Auction-Additional-Bid header.
Oct 17, 2023
4a48a79
Merge branch 'WICG:main' into negative
qingxinwu Oct 17, 2023
b5efcaf
Apply suggestions from code review
qingxinwu Oct 18, 2023
cec0122
Apply suggestions from code review
qingxinwu Oct 19, 2023
fc02ac9
Address comments.
Oct 19, 2023
5b68910
Address remaining comments.
Oct 19, 2023
bee4ccc
Add link to a github issue for TODO.
Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading