[Spec] Additional bids and negative targeting feature #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@morlovich Mind taking a look at the huge spec change for additional bid and negative targeting? Thanks! It might take some time to do a full review, so feel free to send in some comments so that I can start addressing those ealier, while you continue reviewing. @orrb1 FYI, and feel free to review as well, especially the explaination paragraphs. |
qingxinwu
changed the title
qingxinwu
changed the title
orrb1
reviewed
Sep 20, 2023
morlovich
reviewed
Sep 20, 2023
orrb1
reviewed
Sep 20, 2023
Done. |
domfarolino
reviewed
Oct 5, 2023
Merged
domfarolino
reviewed
Oct 18, 2023
Co-authored-by: Dominic Farolino <[email protected]>
domfarolino
reviewed
Oct 19, 2023
Co-authored-by: Dominic Farolino <[email protected]>
|
Addressed all comments. |
This was referenced Oct 20, 2023
domfarolino
approved these changes
Oct 20, 2023
github-actions bot
added a commit
that referenced
this pull request
Oct 20, 2023
SHA: 433120f Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to qingxinwu/turtledove
that referenced
this pull request
Oct 20, 2023
SHA: 433120f Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the explainer PR for the feature.
Patching the fetch method and handling the response header are still todos, waiting for https://github.com/WICG/turtledove/pull/771/files to land, which does similar things for direct from seller signals.
Preview | Diff