New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid uses of [=this=] from algorithms running in parallel #671

Closed

domfarolino opened this issue Jun 26, 2023 · 2 comments

Labels

spec

Collaborator

domfarolino commented Jun 26, 2023 •

edited

Loading

Build trusted bidding signals URL uses [=this=] but is called from in parallel, which is invalid.
Report result does the same in step 6
Generate and score bids does the same, but I guess that's tracked by Generate and score bids parallelism errors #668 too.

The text was updated successfully, but these errors were encountered:

domfarolino added the spec label

domfarolino changed the title ~~Build trusted bidding signals URL~~ Invalid uses of [=this=] from algorithms running in parallel

qingxinwu mentioned this issue

Spec: Fix some errors, such as use of [=this=] in parallel. #875

Merged

Collaborator

qingxinwu commented Oct 23, 2023 •

edited

Loading

Uploaded a PR to fix these:

Build trusted bidding signals URL:
https://github.com/WICG/turtledove/pull/875/files#diff-6f5a1d8263b0b0c42e2716ba5750e3652e359532647ac934c1c70086ae3ceddaR1859
Report result:
96b46f6

Collaborator

qingxinwu commented Nov 6, 2023

Closing this since the fix (PR #875) is merged. Feel free to reopen if anything is missed.

qingxinwu closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment