Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercept nav events and and prevent consequent logic from unfolding? #153

Open
jayarjo opened this issue Jan 28, 2019 · 3 comments
Open

Comments

@jayarjo
Copy link

jayarjo commented Jan 28, 2019

Is there a way to intercept nav events and prevent consequent logic from unfolding? Obviously one can intercept keydown, but that would be cumbersome, would be great if nav events themselves behaved similarly.

@jihyerish
Copy link
Collaborator

@jayarjo Thanks for your feedback!
Yes, as you pointed out, there wasn't the procedure about preventing the navigation events in the previous polyfill.
I updated the polyfill with #156, and now you can prevent the events.

You can see how it works in this demo.

@jayarjo
Copy link
Author

jayarjo commented Feb 25, 2019

@jihyerish great that there's progress on this! But do you actually reset those global flags back to initial value anywhere? Or they are not meant to?

@jihyerish
Copy link
Collaborator

@jayarjo Yes, the flags are used for defining the prevent default behavior for the navigation events. Those flags are set as true when the events are triggered.
And if those flags are set as true, in the processing model flows to the prevented behavior of the corresponding events.

For example, in the polyfill code line 316 -319, it follows the prevented behavior of navbeforescroll.

      if (!navbeforescrollPrevented) {
        moveScroll(container, dir);
        return true;
      }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants