Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explainer for non-fetch requests #125

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Add explainer for non-fetch requests #125

merged 5 commits into from
Feb 1, 2024

Conversation

iVanlIsh
Copy link
Collaborator

No description provided.

johnathan79717
johnathan79717 requested changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@johnathan79717 johnathan79717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good overall. Just a few suggestions.

permission_prompt/explariner_navigation.md Outdated Show resolved Hide resolved
permission_prompt/explariner_navigation.md Outdated Show resolved Hide resolved
permission_prompt/explariner_navigation.md Outdated Show resolved Hide resolved
permission_prompt/explariner_navigation.md Outdated Show resolved Hide resolved
permission_prompt/explariner_navigation.md Outdated Show resolved Hide resolved
permission_prompt/explariner_navigation.md Outdated Show resolved Hide resolved
permission_prompt/explariner_navigation.md Outdated Show resolved Hide resolved
johnathan79717
johnathan79717 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@johnathan79717 johnathan79717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

permission_prompt/explariner_non-fetch_requests.md Outdated Show resolved Hide resolved
@iVanlIsh iVanlIsh merged commit 10350ae into WICG:main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnathan79717 johnathan79717 johnathan79717 approved these changes

Assignees

@johnathan79717 johnathan79717

@iVanlIsh iVanlIsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iVanlIsh @johnathan79717