-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling fallback content for portals #23
Comments
I think this is pretty straightforward. The parser does nothing special with In browsers that do support it, we need a bit of spec work to state that the children are hidden. This ties in to the general spec work needed to state how portals are rendered. |
Should we display fallback content in cases where the portal fails to load, e.g. portals inside nested browsing contexts? |
By failing to load, are we talking about both eligibility of the host (e.g. no nested contexts) and conditions in the portal context (e.g. no network), or just the former? |
Good question. I think we need to consider both. In particular, do we want portals to be able to display error pages? Or should they get closed when that would otherwise show up? This is interesting because, e.g., for iframes, navigating to a blob URL will display an error page. We've chosen instead to close the portal, but now we have to decide where to use closing and where to use error pages. |
I admit to not being super invested in the idea of fallback content, but I would think that the simplest rule is probably that if there's no browsing context we render fallback content instead. |
One of the issues that were brought up in the Chromium intent thread (https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/SgsbpO08AeI) was how to handle fallback content.
I haven't given this a lot of thought yet, but this is something we should consider carefully as we write the spec, since it's important to interop with browser that may not support portals.
The text was updated successfully, but these errors were encountered: