Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activate() should fulfill even if the inner document load failed due to DNS/x-frame-options etc etc #228

Open
jakearchibald opened this issue Jul 10, 2020 · 3 comments
Labels
spec todo A nitty-gritty detail that needs spec work

Comments

@jakearchibald
Copy link
Collaborator

Only just occurred to me that iframes fire their load event even in the case of navigation 'failures'. If we reject in similar cases we're revealing something new.

@jakearchibald jakearchibald added the spec todo A nitty-gritty detail that needs spec work label Jul 10, 2020
@domenic
Copy link
Collaborator

domenic commented Jul 10, 2020

This is somewhat contentious and non-interoperable, actually; see whatwg/html#125, whatwg/html#1230, and whatwg/html#4247.

@jakearchibald
Copy link
Collaborator Author

Hah, perfect. I guess we should just do whatever the spec does right now, and change whenever the spec changes.

@jeremyroman
Copy link
Collaborator

It will certainly be observable to them that they weren't unloaded. Unlike the load event, activate does commit them to going there if it did succeed in loading and so is less useful for passively observing XFO etc than <iframe onload>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec todo A nitty-gritty detail that needs spec work
Projects
None yet
Development

No branches or pull requests

3 participants